Enable vector search test and fix vector search tests #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasin
force-pushed
the
task/enable_vector_search_test
branch
from
43520f6 to
da23bd7
Compare
velicuvlad
approved these changes
Feb 16, 2024
pasin
force-pushed
the
task/enable_vector_search_test
branch
from
da23bd7 to
2c33133
Compare
velicuvlad
reviewed
Feb 16, 2024
| CBLVectorIndexConfiguration* config = [[CBLVectorIndexConfiguration alloc] initWithExpression: @"vector" | ||
| dimensions: 300 | ||
| centroids: 20]; | ||
| AssertEqualObjects(config.encoding, [CBLVectorEncoding scalarQuantizerWithType: kCBLSQ8]); |
There was a problem hiding this comment.
missed this line on first read
* Linked CouchbaseLiteVectorSearch.xcframework from Tests/Extensions folder to the Objective-C’s test targets. The xcframework will not be push to Github. * Added download_vector_search_extension.sh script which will download the extension xcframework based on the version specified in Tests/Extensions/version.txt. * Fixed testVectorIndexConfigurationDefaultValue when checking the default encoding value. * Enabled all tests in VectorSearchTest.m.
pasin
force-pushed
the
task/enable_vector_search_test
branch
from
2c33133 to
106ab84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked CouchbaseLiteVectorSearch.xcframework from Tests/Extensions folder to the Objective-C’s test targets. The xcframework will not be push to Github.
Added download_vector_search_extension.sh script which will download the extension xcframework based on the version specified in Tests/Extensions/version.txt.
Fixed testVectorIndexConfigurationDefaultValue when checking the default encoding value.
Enabled all tests in VectorSearchTest.m.