-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBL-5613: Swift API docs for Scope using Obj-c reference #3284
Conversation
Swift/Collection.swift
Outdated
@@ -2,7 +2,7 @@ | |||
// Collection.swift | |||
// CouchbaseLite | |||
// | |||
// Copyright (c) 2022 Couchbase, Inc All rights reserved. | |||
// Copyright (c) 2024-present Couchbase, Inc All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, we have received this format from legal and all CBL platforms are using the same format. (SG is using 20XX-Present format though).
Before changing the format even though it is small and ok, it would be best to check with the team.
Also we would prefer to have one PR to change the format for all files for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I was working on a another PR to update the license for all the files that have commits newer than the license itself, and are not related to this PR.
I wasn't sure if we want to do that for all files. If that's the case, yes I will make another PR for all files.
AFAIK, for Apache2, the license is valid from the specified year until present implicitly, up to 10 years or something. I saw the format in some other file already and just copied it.
FWIW, I'm ok with only the year if we are already consistent across CBL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've talked with SGW and they use a tool for updating the copyright paragraph and also to generate one for every new file created. very interesting. I'll look into it if time permits.
I've revert the license date changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah.... I if "present" works, it is the first I've heard of it. It would be very nice if we can use it, though. Please let me know how this goes....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you get all sorts of brownie points for doing this stuff...
* fix obj-c ref in swift api * fix some other mistakes or spacing within Swift API Docs
* CBL-5524 : Add all keys to the Privacy Manifest file (#3258) * CBL-5541 : Update vector search test per changes in v1.8 (#3260) * CBL-5365: Remove CBLErrors.h from Swift Public API (#3271) * CBL-5508: Update Min macOS Support Version to 12.0 (#3272) * CBL-5693 : Fix missing exported symbols (#3281) * CBL-5222: MutableDocument should be usable before creating a database instance (#3278) * CBL-5613: Swift API docs for Scope using Obj-c reference (#3284) * CBL-5710: Add note that the replicator cannot be started in the inBatch() function (#3286) * CBL-5514: Swift MutableDocument's collection is not set when a new document is saved (#3287) * CBL-5660 : Fix a released query context may be used in observer callback (#3285) * CBL-5668: Get Code Coverage at least 80% (#3289) * CBL-3385: Allow null expression parameter for Function.count(expression) (#3290) * CBL-5750 + CBL-5757 Lazy Index - ObjC (#3291) * CBL-5811 : Support Vector Dimension to 4096 and Vector in Base64 String (#3294) * CBL-5803 : Implement Lazy Vector Index and Test for Swift (#3295) * CBL-5567 : Implement log replicator heiroglyphics (#3296) * CBL-5859 : Allow explicitly enable vector search (#3297) * CBL-5886: Add missing numProbes and correct min/maxTrainingSize default value (#3298) * CBL-5932: Update default constants and public symbols (#3299) * CBL-5928 : CBLErrors.h is not included in the umbrella header (#3301) * CBL-5927 : Fix Duplicate CBLQueryIndex Interface Definition (#3300) * CBL-5893: Throw exception for everything if finish() was successfully called beforehand (#3302) * CBL-5956: Update DistanceMetric (#3303) * CBL-5690 : Update Distance Metric Enum and VS SQL in Tests (#3304) * CBL-5990 : Fix _kCBLDefaultLogFileUsePlaintext symbol (#3305) * CBL-6070: Implement Database Full-Sync Option (#3318) * CBL-6144: Add testConcurrentCreateAndQuery to verify query's lock (#3320) * CBL-6191 : Fix null URL for proxy CONNECT request (#3324) * CBL-5180: Implement Array Index API (#3327) * CBL-5181: Array Index API tests and adjustments (#3330) * CBL-5899 * CBL-6307: Database MMap Configuration API and tests (#3333) * CBL-6349: Implement Document's getRevisionHistory() for E2E Test Server (#3335) * LiteCore 3.2.1-19 * Export symbol for mmap constant (#3341) * ArrayIndexConfiguration explicit expressions arg on set (#3342) --------- Co-authored-by: Pasin Suriyentrakorn <pasin@couchbase.com>
No description provided.