Objc-c new logging api implementation #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pasin
commented
Dec 17, 2024
•
pasin
commented
- Implemented the logic to init CBLLogSinks.
- Implemented the logic to setup each log sink.
- Implemented a minium locking with a note comment in the CBLLogSinks implementation.
- Changed the old logging API to use the new log sink API.
- No tests for the new logging API implemented.
- No guard for using both old and new API implemented.
- PR validation can't be run when having a PR to non release branch or main branch for some reason.
* Implemented the logic to init CBLLogSinks. * Implemented the logic to setup each log sink. * Implemented a minium locking with a note comment in the CBLLogSinks implementation. * Changed the old logging API to use the new log sink API.
pasin
changed the title
|
yes, PR validation is only set for master/release. It needs modification into the yaml to run for every branch - there is no way to enable it on-fly. I've tested locally and everything is fine. I looked around today on how to handle the situation of old/new api use. Apple doesn't provide any "intelligent" way to do this and as far as I've skim around for ways to do such thing, I will move forward with a similar solution of what you've done for C. I will merge this now as I already started making changes on local on top. I do have a question that I will take with you offline - it is concept related. |
velicuvlad
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.