Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my fix for #648. Intentionally excluding NSDate in the NSObject subclass check since it is handled best in the final else catch-all case, and NSObject handing of NSDate is not appropriate/does not work. Maybe more elegant way to implement this as there might be other cases (e.g. other classes) that the coe should be letting the final catch-all else handle using ValueConverter handle (I doubt NSDate is the only such case?), but wanted to avoid significantly changing the structure/flow of this code as it is not originally my code and my understanding of it is not good enough and wanted to leave the least trace possible with this fix, I can imagine reworking this in a few ways to handle this, but it would probably change the method and break other cases, so excluding NSDate subclasses in the NSObject else if I added for now...
#648