Remove some inappropriate logging lines since redaction is not in pla…

…y anymore (until further notice)
couchbase · Jun 1, 2018 · 0d4f930 · 0d4f930
1 parent 2f7e678
commit 0d4f930
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/src/Couchbase.Lite.Shared/Log/SecureLogString.cs b/src/Couchbase.Lite.Shared/Log/SecureLogString.cs
@@ -125,9 +125,9 @@ internal sealed class SecureLogJsonString : SecureLogItem
 
         #endregion
 
-        [NotNull]
         #region Properties
-
+
+        [NotNull]
         private string String 
         {
             get {

diff --git a/src/Couchbase.Lite.Shared/Sync/HTTPLogic.cs b/src/Couchbase.Lite.Shared/Sync/HTTPLogic.cs
@@ -166,15 +166,12 @@ public void ReceivedResponse(HttpMessageParser parser)
 
                     if (_authorizationHeader == null && Credential != null) {
                         _authorizationHeader = CreateAuthHeader(authResponse);
-                        var password = new SecureLogString(Credential.Password, LogMessageSensitivity.Insecure);
-                        Log.To.Sync.I(Tag, $"Auth challenge; credential = {Credential.UserName} / {password}");
+                        Log.To.Sync.I(Tag, $"Auth challenge received for {Credential.UserName}");
                         ShouldRetry = true;
                         break;
                     }
 
-                    var auth = new SecureLogString(_authorizationHeader, LogMessageSensitivity.Insecure);
-                    var wwwAuth = new SecureLogString(authResponse, LogMessageSensitivity.Insecure);
-                    Log.To.Sync.I(Tag, $"HTTP auth failed; sent Authorization {auth} ; got WWW-Authenticate {wwwAuth}");
+                    Log.To.Sync.I(Tag, "HTTP auth failed");
                     Error = new CouchbaseNetworkException(httpStatus);
                     break;
                 default:

diff --git a/src/Couchbase.Lite.Shared/Sync/ReplicatorOptionsDictionary.cs b/src/Couchbase.Lite.Shared/Sync/ReplicatorOptionsDictionary.cs
@@ -198,7 +198,7 @@ internal ReplicatorOptionsDictionary([NotNull]Dictionary<string, object> raw) :
                 foreach (var entry in split) {
                     var pieces = entry?.Split('=');
                     if (pieces?.Length != 2) {
-                        Log.To.Sync.W(Tag, "Garbage cookie value, ignoring:  {0}", new SecureLogString(entry, LogMessageSensitivity.Insecure));
+                        Log.To.Sync.W(Tag, "Garbage cookie value, ignoring");
                         continue;
                     }