Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AV-76499] Support Capella System Events and Activity Logs #206

Merged
merged 11 commits into from
Aug 28, 2024

Conversation

aniket-Kumar-c
Copy link
Collaborator

@aniket-Kumar-c aniket-Kumar-c commented Jul 11, 2024

Jira

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Type of Change

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

  • Manually tested
  • Unit tested
  • Acceptance tested
  • Unable to test / will not test (Please provide comments in section below)

Testing

Testing

Required Checklist:

  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if required)
  • I have run make fmt and formatted my code

Further comments

@aniket-Kumar-c aniket-Kumar-c requested review from a team as code owners July 11, 2024 05:05
@aniket-Kumar-c aniket-Kumar-c self-assigned this Jul 11, 2024
@aniket-Kumar-c
Copy link
Collaborator Author

Validation are added in respective readme file

Copy link
Contributor

@PaulomeeCb PaulomeeCb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aniket-Kumar-c Changes lgtm! just a question, do we need to update the README of the getting started folder? Or will it remain separately as we cant have the events along with the other resources (i.e. like how we update the getting_started variables.tf and terraform.template.tfvars for resources together)

PaulomeeCb
PaulomeeCb previously approved these changes Aug 10, 2024
Copy link
Contributor

@PaulomeeCb PaulomeeCb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 , just some nits and please remove the lint errors. Thanks for change!

Copy link
Contributor

@PaulomeeCb PaulomeeCb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@aniket-Kumar-c aniket-Kumar-c merged commit 70f7efd into main Aug 28, 2024
4 checks passed
@aniket-Kumar-c aniket-Kumar-c added the enhancement New feature or request label Sep 11, 2024
@aniket-Kumar-c aniket-Kumar-c changed the title [AV-76499] System events and activity logs [AV-76499] Support Capella System Events and Activity Logs Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants