-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AV-76499] Support Capella System Events and Activity Logs #206
[AV-76499] Support Capella System Events and Activity Logs #206
Conversation
…ouchbase-capella into AV-77965_audit_log_acceptance_test
…ouchbase-capella into AV-76499_system_events_and_activity_logs
Validation are added in respective readme file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aniket-Kumar-c Changes lgtm! just a question, do we need to update the README of the getting started folder? Or will it remain separately as we cant have the events along with the other resources (i.e. like how we update the getting_started variables.tf
and terraform.template.tfvars
for resources together)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 , just some nits and please remove the lint errors. Thanks for change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
Jira
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Type of Change
Manual Testing Approach
How was this change tested and do you have evidence? (REQUIRED: Select at least 1)
Testing
Testing
Required Checklist:
Further comments