-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AV-83476 - Enable dns private resolution in cluster creation #212
Merged
+213
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closing as stale, please reopen when ready to merge |
PaulomeeCb
force-pushed
the
AV-83476_enable_dns_private_resolution
branch
from
September 23, 2024 19:45
77b1246
to
e03e90f
Compare
aniket-Kumar-c
previously approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SaicharanCB
previously approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
l0n3star
approved these changes
Oct 10, 2024
Lagher0
added a commit
that referenced
this pull request
Oct 22, 2024
* main: AV-83476 - Enable dns private resolution in cluster creation (#212)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Type of Change
Manual Testing Approach
How was this change tested and do you have evidence? (REQUIRED: Select at least 1)
Testing
Testing
enable_private_dns_resolution = true
-terraform apply-
enable_private_dns_resolution = true
terraform apply -
enable_private_dns_resolution = false
for new cluster-Created successfully-
We can see
"enablePrivateDNSResolution": true
for cluster391eb24a-52ef-4071-b249-956783712473
, and none for the other one.391eb24a-52ef-4071-b249-956783712473
,managementHostname
is populated -Required Checklist:
Further comments