Upgrade to v4.0 #265
Merged
Upgrade to v4.0 #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethnym
added
dependencies
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>
* fix: add missing Table.Container element * Address review feedback
* Define <Element /> and <Box /> component types * Add typedefs for more components * Add typedefs for more components * Try to add support for renderAs prop * brute forced every single html elements to apply dynamic props based on renderAs * removed some html elements because too many cases breaks ts * removed more html elements for renderAs props * removed more html elements for renderAs props * Tries to fix renderAs dynamic prop typing * Clean up the code * Add types for more components * Tidy up code * Add types for more components * Add types for the remaining components * clean up the code * remove ref attribute; fix menu type def * Add Table.Container type * Add Table hoverable prop * Remove List component
|
@couds is this typescript structure good? |
wdyt about moving the definitions that still are inside the |
|
yeah that sounds alright to me. but how about a file called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks the upgrade of this library to v4.0
Closes #262