Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add access to json body content via req and beresp #44

Closed
malud opened this issue Oct 7, 2020 · 0 comments · Fixed by #34
Closed

Add access to json body content via req and beresp #44

malud opened this issue Oct 7, 2020 · 0 comments · Fixed by #34
Assignees
@malud
Labels
enhancement New feature or request theme/config

Comments

@malud
Copy link
Collaborator

malud commented Oct 7, 2020

Accessing a bodies json payload is crucial for at least header enrichment in both directions. This will be a useful option for some new features later on.

The request (req) and response (beresp) evaluation needs to be extended with json_body.
Since we have to buffer and may rewind the body content for further processing a limit is a requirement:

request/response_body_limit or body_limit for both directions.

Buffering those bodies should be known in general on startup/config load. Detecting the json_body usage within a backend block. This enables some kind of lazy loading for json_body if used in config and with the http method matches POST PUT or PATCH and content-type application/json.
@malud malud added the enhancement New feature or request label Oct 7, 2020
@malud malud self-assigned this Oct 7, 2020
@malud malud linked a pull request Oct 7, 2020 that will close this issue
Add 'json_body' as config req variable #34
Merged
malud pushed a commit that referenced this issue Oct 9, 2020
Add 'json_body' as config req variable #44
2f002d2
malud pushed a commit that referenced this issue Oct 9, 2020
Determine buffering if req or beresp json_body response occurs in hcl…
98909db 
….bodies #44
malud pushed a commit that referenced this issue Oct 9, 2020
support more complex types in seetie eval conversion #44
2ba285a
malud pushed a commit that referenced this issue Oct 9, 2020
Fixup tests and rewind body #44
9344b81
malud pushed a commit that referenced this issue Oct 9, 2020
Use const definition for config variables #44
f69cfe4
malud pushed a commit that referenced this issue Oct 9, 2020
Enabled and simplified context eval test #44
68e15c5
malud pushed a commit that referenced this issue Oct 9, 2020
Add req.json_body test #44
03aee0b
malud pushed a commit that referenced this issue Oct 9, 2020
Add hcltest and go-units to vendor directory #44
549df92 
updated hcl to v2.6.0
malud pushed a commit that referenced this issue Oct 9, 2020
Add request_body_limit option #44
3446324
malud pushed a commit that referenced this issue Oct 19, 2020
Add 'json_body' as config req variable #44
4a806d1
malud pushed a commit that referenced this issue Oct 19, 2020
Determine buffering if req or beresp json_body response occurs in hcl…
3233421 
….bodies #44
malud pushed a commit that referenced this issue Oct 19, 2020
support more complex types in seetie eval conversion #44
2908aea
malud pushed a commit that referenced this issue Oct 19, 2020
Fixup tests and rewind body #44
21cedfe
malud pushed a commit that referenced this issue Oct 19, 2020
Use const definition for config variables #44
063b255
malud pushed a commit that referenced this issue Oct 19, 2020
Enabled and simplified context eval test #44
b90f256
malud pushed a commit that referenced this issue Oct 19, 2020
Add req.json_body test #44
83c01fa
malud pushed a commit that referenced this issue Oct 19, 2020
Add hcltest and go-units to vendor directory #44
f9f7612 
updated hcl to v2.6.0
malud pushed a commit that referenced this issue Oct 19, 2020
Add request_body_limit option #44
80f1a0b
malud pushed a commit that referenced this issue Oct 20, 2020
Add 'json_body' as config req variable #44
cb28acb
malud pushed a commit that referenced this issue Oct 20, 2020
Determine buffering if req or beresp json_body response occurs in hcl…
49e0e1c 
….bodies #44
malud pushed a commit that referenced this issue Oct 20, 2020
support more complex types in seetie eval conversion #44
56f01fc
malud pushed a commit that referenced this issue Oct 20, 2020
Fixup tests and rewind body #44
ae7306d
malud pushed a commit that referenced this issue Oct 20, 2020
Use const definition for config variables #44
ae922fd
malud pushed a commit that referenced this issue Oct 20, 2020
Enabled and simplified context eval test #44
6be2cd2
malud pushed a commit that referenced this issue Oct 20, 2020
Add req.json_body test #44
3e33faf
malud pushed a commit that referenced this issue Oct 20, 2020
Add hcltest and go-units to vendor directory #44
cfc1408 
updated hcl to v2.6.0
malud pushed a commit that referenced this issue Oct 20, 2020
Add request_body_limit option #44
c6b87f0
malud pushed a commit that referenced this issue Oct 20, 2020
Add context test for a GET (body) request #44
03b3945
malud pushed a commit that referenced this issue Oct 20, 2020
Handle request body access for almost all http methods if a body is g…
dc4e394 
…iven (json_body) #44

Does not affect post form parsing

Introduce test helper
malud pushed a commit that referenced this issue Oct 20, 2020
Handle unsupported attribute ref access #44
61a4999
malud pushed a commit that referenced this issue Oct 21, 2020
Move proxy options unit parsing to newProxyOpts func #44
adfce8e
malud pushed a commit that referenced this issue Oct 21, 2020
Fixup expr variable lookup, simplified traversal step access #44
ce7ddd2
malud pushed a commit that referenced this issue Oct 23, 2020
Add 'json_body' as config req variable #44
4365517
malud pushed a commit that referenced this issue Oct 23, 2020
Determine buffering if req or beresp json_body response occurs in hcl…
37c7256 
….bodies #44
malud pushed a commit that referenced this issue Oct 23, 2020
support more complex types in seetie eval conversion #44
6b070a5
malud pushed a commit that referenced this issue Oct 23, 2020
Fixup tests and rewind body #44
fe11394
malud pushed a commit that referenced this issue Oct 23, 2020
Use const definition for config variables #44
61865b5
malud pushed a commit that referenced this issue Oct 23, 2020
Enabled and simplified context eval test #44
58a95e0
malud pushed a commit that referenced this issue Oct 23, 2020
Add req.json_body test #44
2214bf8
malud pushed a commit that referenced this issue Oct 23, 2020
Add hcltest and go-units to vendor directory #44
be952b7 
updated hcl to v2.6.0
malud pushed a commit that referenced this issue Oct 23, 2020
Add request_body_limit option #44
ef3c878
malud pushed a commit that referenced this issue Oct 23, 2020
Add context test for a GET (body) request #44
296694f
malud pushed a commit that referenced this issue Oct 23, 2020
Handle request body access for almost all http methods if a body is g…
bee832d 
…iven (json_body) #44

Does not affect post form parsing

Introduce test helper
malud pushed a commit that referenced this issue Oct 23, 2020
Handle unsupported attribute ref access #44
2b029e6
malud pushed a commit that referenced this issue Oct 23, 2020
Move proxy options unit parsing to newProxyOpts func #44
66855e9
malud pushed a commit that referenced this issue Oct 23, 2020
Fixup expr variable lookup, simplified traversal step access #44
5b6b287
malud pushed a commit that referenced this issue Oct 23, 2020
Fix a panic for unknown cty types, return cty.NullVal of type cty.Str…
8953636 
…ing as fallback #44

Add test for json 'null' values
malud pushed a commit that referenced this issue Oct 23, 2020
Fix a panic for unknown cty types, return cty.NullVal of type cty.Str…
1ba609c 
…ing as fallback #44

Add test for json 'null' values
malud pushed a commit that referenced this issue Oct 26, 2020
Fix a panic for unknown cty types, return cty.NullVal of type cty.Str…
ca5b4c0 
…ing as fallback #44

Add test for json 'null' values
malud pushed a commit that referenced this issue Oct 26, 2020
Add json_body and request_body_limit documentation #44
9824608
malud pushed a commit that referenced this issue Oct 26, 2020
Add json_body and request_body_limit documentation #44
1dbf5ae
malud pushed a commit that referenced this issue Oct 27, 2020
Add json_body and request_body_limit documentation #44
dc5fd32
vwuerbel pushed a commit that referenced this issue Oct 29, 2020
Add json_body and request_body_limit documentation #44 (#60)
3d93a69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malud malud

Labels
enhancement New feature or request theme/config
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'json_body' as config req variable coupergateway/couper
1 participant
@malud