Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix json type assumption #177

Merged
merged 4 commits into from
Apr 1, 2021
Merged

Fix json type assumption #177

merged 4 commits into from
Apr 1, 2021

Conversation

malud
Copy link
Collaborator

@malud malud commented Apr 1, 2021

Use a more generic approach and convert to explicit cty types later on

Closes #165

Marcel Ludwig added 3 commits April 1, 2021 11:28
Fix json type assumption
fab339f 
Use a more generic approach and convert to explicit cty types later on
Use cty json to unmarshal all types
f552d6e
Fixup handle null values
750f5ef
@malud malud requested a review from johakoch April 1, 2021 10:17
@malud malud linked an issue Apr 1, 2021 that may be closed by this pull request
Empty json array encodes to null. #162
Closed
@johakoch johakoch merged commit 817ca62 into master Apr 1, 2021
@johakoch johakoch deleted the fix-empty-req-vars branch April 1, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johakoch johakoch johakoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

req.json_body result is an empty object for specific types Empty json array encodes to null.
2 participants
@malud @johakoch