Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upstream request/response validation with openapi (#21) #22

Merged
merged 30 commits into from
Dec 14, 2020
Merged

Add upstream request/response validation with openapi (#21) #22

merged 30 commits into from
Dec 14, 2020

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Sep 17, 2020 •
edited by malud
Loading

  • implementation
  • documentation

@johakoch johakoch linked an issue Sep 17, 2020 that may be closed by this pull request
OpenAPI upstream request/response validation #21
Closed
2 tasks
@johakoch johakoch changed the title WIP: Add upstream request/response validation with swagger (#21) WIP: Add upstream request/response validation with swagger/openapi (#21) Sep 17, 2020
@johakoch johakoch changed the title WIP: Add upstream request/response validation with swagger/openapi (#21) WIP: [POC] Add upstream request/response validation with swagger/openapi (#21) Sep 18, 2020
@malud malud changed the title WIP: [POC] Add upstream request/response validation with swagger/openapi (#21) [POC] Add upstream request/response validation with swagger/openapi (#21) Oct 1, 2020
@malud malud marked this pull request as draft October 1, 2020 07:42
@johakoch johakoch force-pushed the validation branch 3 times, most recently from c036380 to 9e66f29 Compare October 8, 2020 10:48
@johakoch johakoch changed the title [POC] Add upstream request/response validation with swagger/openapi (#21) [POC] Add upstream request/response validation with openapi (#21) Oct 8, 2020
malud
malud requested changes Oct 9, 2020
View reviewed changes
handler/proxy.go Outdated Show resolved Hide resolved
handler/proxy.go Outdated Show resolved Hide resolved
@johakoch johakoch force-pushed the validation branch 6 times, most recently from abdcb46 to 6c446df Compare October 15, 2020 08:54
@malud malud mentioned this pull request Oct 23, 2020
Merged
@malud malud force-pushed the validation branch 2 times, most recently from 1958719 to dc41a8d Compare December 2, 2020 07:19
@malud malud modified the milestone: 0.3 Dec 2, 2020
@malud malud changed the title [POC] Add upstream request/response validation with openapi (#21) Add upstream request/response validation with openapi (#21) Dec 4, 2020
@malud malud marked this pull request as ready for review December 7, 2020 16:34
alex-schneider
alex-schneider reviewed Dec 8, 2020
View reviewed changes
config/backend.go Outdated Show resolved Hide resolved
alex-schneider
alex-schneider reviewed Dec 8, 2020
View reviewed changes
config/backend.go Outdated Show resolved Hide resolved
Johannes Koch and others added 14 commits December 9, 2020 17:05
keep backend status code in log even in case of response validation e…
8622993 
…rror (#21)
validation message in backend log's message field (#21)
f46c641
tests for validation (#21)
f8839d6
extracted OpenAPI validator (#21)
627fa8c
Fixed validation errors in openapi file to be logged as errors instea…
d1a762d 
…d of panic (#21)
Fixup openAPI validation test
92fe110
Handle body rewind
02dd6f3 
Refactor openAPI error handling
Fix set getBody method first #72
b023a88 
Leads to getAttribute errors for recently added dynamic evals for origin, path and hostname
Add buffer stringer implementation
d318402 
Add stringer tool to generate for const
Add test for bufferOption interaction
99d19c8
rm httpbin.yaml
b6f203e
Fix documentation hcl format
8e85907
Remove loose punctuation mark from documentation
682d51a 
Fix couper version to latest release
Add openapi documentation and example link
121edd1
@malud malud merged commit 8feffb2 into master Dec 14, 2020
@malud malud deleted the validation branch December 14, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider left review comments

@malud malud malud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenAPI upstream request/response validation
3 participants
@johakoch @malud @alex-schneider