Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Panic in jwt_sign() function #242

Merged
merged 26 commits into from
Jun 25, 2021
Merged

Fix: Panic in jwt_sign() function #242

merged 26 commits into from
Jun 25, 2021

Conversation

alex-schneider
Copy link
Contributor

No description provided.

@alex-schneider alex-schneider linked an issue May 25, 2021 that may be closed by this pull request
Call of jwt_sign() and saml_sso_url() panics #243
Closed
malud
malud reviewed May 26, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
malud
malud requested changes Jun 3, 2021
View reviewed changes
accesscontrol/jwt.go Outdated Show resolved Hide resolved
accesscontrol/jwt_test.go Outdated Show resolved Hide resolved
config/runtime/server.go Outdated Show resolved Hide resolved
config/runtime/server.go Outdated Show resolved Hide resolved
config/runtime/server.go Outdated Show resolved Hide resolved
errors/error.go Outdated Show resolved Hide resolved
errors/jwt.go Outdated Show resolved Hide resolved
errors/jwt.go Outdated Show resolved Hide resolved
errors/jwt.go Outdated Show resolved Hide resolved
malud
malud requested changes Jun 9, 2021
View reviewed changes
Copy link
Collaborator

@malud malud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some refinements required.

config/runtime/server.go Outdated Show resolved Hide resolved
config/runtime/server.go Outdated Show resolved Hide resolved
eval/lib/jwt.go Outdated Show resolved Hide resolved
eval/lib/jwt.go Outdated Show resolved Hide resolved
eval/lib/jwt.go Show resolved Hide resolved
config/validate/jwt.go Outdated Show resolved Hide resolved
@malud malud mentioned this pull request Jun 14, 2021
Merged
Alex Schneider and others added 15 commits June 15, 2021 09:06
Ensure, that funcs are always available
5b2b5eb
Check for valid PEM format
5f9a862
Test
f8e8dcd
Changelog
ff277fd
Check for key errors on startup, too
7ea94ab
DRY: use the same code for jwt and jwt_signing_profile
ca862bf
Update CHANGELOG.md
7afad66 
Co-authored-by: Marcel Ludwig <marcel.ludwig@avenga.com>
Use the With() method
31a1dc1 
Co-authored-by: Marcel Ludwig <marcel.ludwig@avenga.com>
Use the With() method
418bcbc 
Co-authored-by: Marcel Ludwig <marcel.ludwig@avenga.com>
Use the With() method
ecd1b5e 
Co-authored-by: Marcel Ludwig <marcel.ludwig@avenga.com>
Naming: Validate => Load
ebeb256
Remove JwtSigningError type
6a0732d
Modify error message
25d5c6e
Move the validation code to a new package
7f4776e
Fix jwt key loading and related error messages
f1b9b00 
jwt signing profile method used already read keys now

refactor: saml2 file load with same method as jwt/jwt_signing_profile
alex-schneider
alex-schneider commented Jun 23, 2021
View reviewed changes
config/reader/file.go Outdated Show resolved Hide resolved
@malud malud merged commit faf042f into master Jun 25, 2021
@malud malud deleted the jwt-sign-panic branch June 25, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johakoch johakoch johakoch left review comments

@malud malud malud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call of jwt_sign() and saml_sso_url() panics
3 participants
@alex-schneider @malud @johakoch