Global response headers #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-schneider
force-pushed
the
global-response-headers
branch
from
514b72a
to
7235405
Compare
malud
force-pushed
the
global-response-headers
branch
from
7235405
to
3971fd6
Compare
malud
reviewed
Jun 2, 2021
server/writer/gzip.go
Outdated
| @@ -93,3 +96,5 @@ func ModifyAcceptEncoding(header http.Header) { | |||
| header.Del(AcceptEncodingHeader) | |||
| } | |||
| } | |||
|
|
|||
| func (g *Gzip) AddModifier(_ *eval.Context, _ []hcl.Body) {} | |||
There was a problem hiding this comment.
Should be removed here. Just define this Method as own interface instead of using the writer if required. As I can see, there are explicit type assertions instead of using the writer interface.
malud
force-pushed
the
global-response-headers
branch
from
560ce34
to
7c2035e
Compare
malud
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.