Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform log format fields #300

Merged
merged 13 commits into from
Aug 27, 2021
Merged

Uniform log format fields #300

merged 13 commits into from
Aug 27, 2021

Conversation

Buphido
Copy link
Contributor

@Buphido Buphido commented Aug 23, 2021 •
edited by malud
Loading

Closes #297

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

malud
malud requested changes Aug 26, 2021
View reviewed changes
couper.code-workspace Outdated Show resolved Hide resolved
logging/upstream_log.go Outdated Show resolved Hide resolved
logging/upstream_log.go Show resolved Hide resolved
public/couper.hcl Outdated Show resolved Hide resolved
malud
malud requested changes Aug 27, 2021
View reviewed changes
Copy link
Collaborator

@malud malud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far. We have missed the realtime field. See the updated issue #297 .

@malud
Copy link
Collaborator

malud commented Aug 27, 2021

Thanks @Buphido

@malud malud merged commit eb1ce9d into coupergateway:master Aug 27, 2021
@Buphido Buphido deleted the Uniform-Log-Format-fields branch August 27, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log-Format fields are non-uniform
2 participants
@Buphido @malud