Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix response-writer buffer behaviour #301

Merged
merged 3 commits into from
Aug 26, 2021
Merged

Fix response-writer buffer behaviour #301

merged 3 commits into from
Aug 26, 2021

Conversation

malud
Copy link
Collaborator

@malud malud commented Aug 26, 2021

Fixing weak buffering behaviour for the response-writer. Don't work with p argument.
Rare cases leads to data-races with p and with slicecopy.

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@alex-schneider alex-schneider merged commit dbb997b into master Aug 26, 2021
@alex-schneider alex-schneider deleted the fix-response-write branch August 26, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malud @alex-schneider