Backend Healthcheck #313
Merged
Backend Healthcheck #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buphido
force-pushed
the
backend-health-probes
branch
from
eb2352e
to
8de8da6
Compare
Buphido
force-pushed
the
backend-health-probes
branch
from
d172da0
to
ea1b6f1
Compare
malud
requested changes
Sep 30, 2021
malud
requested changes
Oct 1, 2021
handler/transport/probe.go
Outdated
| req = req.WithContext(context.WithValue(context.Background(), request.URLAttribute, origin)) | ||
| return b.evalTransport(req) | ||
| } | ||
|
|
||
| func (b *Backend) NewProbe() { |
There was a problem hiding this comment.
Just NewProbe() *Probe and assign the result within NewBackend().
| ctx, cancel := context.WithDeadline(context.Background(), time.Now().Add(p.timeOut)) | ||
| res, err := http.DefaultClient.Do(req.WithContext(ctx)) | ||
| ctx, cancel := context.WithDeadline(context.Background(), time.Now().Add(p.Opts.Timeout)) | ||
| res, err := http.DefaultClient.Do(p.Req.WithContext(ctx)) |
There was a problem hiding this comment.
Maybe you could make use of the logger (given to the backend) to at least debug log those request errors.
Putting the log next to your current //print...:90 you could also provide the current state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic healthcheck implemented in file probe.go
Reviewer checklist