Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic claims #314

Merged
merged 69 commits into from
Sep 24, 2021
Merged

Dynamic claims #314

merged 69 commits into from
Sep 24, 2021

Conversation

johakoch
Copy link
Collaborator

JWT claims are now evaluated per request to allow e.g.

    endpoint "/{p}/jwt" {
      access_control = [ "my_jwt" ]
      ...
    }

...

  jwt "my_jwt" {
    ...
    claims = {
      ...
      pid = request.path_params.p
    }
  }

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch marked this pull request as ready for review September 14, 2021 08:34
Copy link
Collaborator

@malud malud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to do.

accesscontrol/jwt.go Show resolved Hide resolved
accesscontrol/jwt.go Outdated Show resolved Hide resolved
accesscontrol/jwt.go Outdated Show resolved Hide resolved
@alex-schneider alex-schneider merged commit fc2b5df into master Sep 24, 2021
@alex-schneider alex-schneider deleted the dynamic-claims branch September 24, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants