Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept forwarded host with port #360

Merged
merged 6 commits into from
Oct 27, 2021
Merged

accept forwarded host with port #360

merged 6 commits into from
Oct 27, 2021

Conversation

johakoch
Copy link
Collaborator

Fixed handling of accept_forwarded_url host if xfh contains a port

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch marked this pull request as ready for review October 26, 2021 13:49
@johakoch johakoch changed the title accept forwarded host with port Draft: accept forwarded host with port Oct 26, 2021
@johakoch johakoch changed the title Draft: accept forwarded host with port accept forwarded host with port Oct 26, 2021
@johakoch johakoch marked this pull request as draft October 26, 2021 16:14
Johannes Koch added 2 commits October 27, 2021 10:35
append port if one was initially present, but xfh contains no port; a…
5a61882 
…dded more test cases; TODO: check test cases for TestHTTPServer_XFH_AcceptingForwardedUrl (combination with xfh = true)
test case expectations are ok
91b76b1
@johakoch johakoch marked this pull request as ready for review October 27, 2021 10:10
@alex-schneider alex-schneider merged commit b72ee2d into master Oct 27, 2021
@alex-schneider alex-schneider deleted the accepts-forwarded-host-with-port branch October 27, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @alex-schneider