Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS and access controls #366

Merged
merged 14 commits into from
Nov 9, 2021
Merged

CORS and access controls #366

merged 14 commits into from
Nov 9, 2021

Conversation

johakoch
Copy link
Collaborator

CORS is now handled before the access controls, so that preflight requests do not reach the access control. Non-preflight requests are passed to the access controls if the origin is allowed.


Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch marked this pull request as ready for review October 29, 2021 12:32
alex-schneider
alex-schneider previously approved these changes Nov 9, 2021
@alex-schneider alex-schneider merged commit 208c331 into master Nov 9, 2021
@alex-schneider alex-schneider deleted the cors-and-acs branch November 9, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants