Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing type checks while using index expressions #391

Merged
merged 7 commits into from
Nov 24, 2021
Merged

Fix missing type checks while using index expressions #391

merged 7 commits into from
Nov 24, 2021

Conversation

malud
Copy link
Collaborator

@malud malud commented Nov 23, 2021 •
edited
Loading

This PR catches missing handling for index expression handling with different index key types.

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@malud malud marked this pull request as ready for review November 24, 2021 07:59
johakoch
johakoch previously approved these changes Nov 24, 2021
View reviewed changes
@johakoch johakoch merged commit 8ede2ca into master Nov 24, 2021
@johakoch johakoch deleted the check-type branch November 24, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johakoch johakoch johakoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malud @johakoch