Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Id token check #393

Merged
merged 4 commits into from
Nov 25, 2021
Merged

Id token check #393

merged 4 commits into from
Nov 25, 2021

Conversation

johakoch
Copy link
Collaborator

  • checks for missing aud claim or aud claim with null value
  • checks for iat claim with non-number value
Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch marked this pull request as ready for review November 24, 2021 15:43
@alex-schneider alex-schneider self-assigned this Nov 25, 2021
@alex-schneider alex-schneider merged commit 71a71bc into master Nov 25, 2021
@alex-schneider alex-schneider deleted the id-token-check branch November 25, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees

@alex-schneider alex-schneider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @alex-schneider