Ci platform build fixups #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 26, 2021 09:30
add prerelease event for testing purposes
log after possible configuration errors
malud
force-pushed
the
ci-platform-build-fixups
branch
from
328e3c0
to
2022738
Compare
afflerbach
reviewed
Nov 26, 2021
|
Looks correct, I haven't checked the binaries, though. |
afflerbach
previously approved these changes
Nov 26, 2021
Co-authored-by: Joe Afflerbach <joe.afflerbach@avenga.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the build-date output from the version command for all builds.
Also excludes ulimit startup log for windows platform introduced in #383.
Some ci fixups regarding the build args
Reviewer checklist