Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ci) Fix build version on linux/win builds #446

Merged
merged 1 commit into from
Feb 28, 2022
Merged

(ci) Fix build version on linux/win builds #446

merged 1 commit into from
Feb 28, 2022

Conversation

malud
Copy link
Collaborator

@malud malud commented Feb 25, 2022

Describe your changes!

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

afflerbach
afflerbach approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@afflerbach afflerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flags do work now:

…
go build -o build-artifacts-1646043034/couper -ldflags '-X github.com/avenga/couper/utils.VersionName=v1.7.1-joe -X github.com/avenga/couper/utils.BuildName=a1b7211 -X github.com/avenga/couper/utils.BuildDate=2022-02-28'

@afflerbach afflerbach merged commit 5697ed5 into master Feb 28, 2022
@afflerbach afflerbach deleted the ci-build-version-fix branch February 28, 2022 10:50
malud pushed a commit that referenced this pull request Mar 3, 2022
(ci) Fix build version on linux/win builds (#446)
169506d 
(cherry picked from commit 5697ed5)
malud pushed a commit that referenced this pull request Mar 7, 2022
(ci) Fix build version on linux/win builds (#446)
695f29c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afflerbach afflerbach afflerbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malud @afflerbach