Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple error handler labels 2 #462

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Multiple error handler labels 2 #462

merged 3 commits into from
Apr 4, 2022

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Mar 30, 2022 •
edited by malud
Loading

Create one kindContents per error_handler block to allow for multiple error_handler labels

This fix unblocks a related refinement for #437

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch force-pushed the multiple-error_handler-labels-2 branch from e4c8c30 to 5252f47 Compare March 30, 2022 10:00
@johakoch johakoch marked this pull request as ready for review March 30, 2022 11:35
@malud malud mentioned this pull request Apr 4, 2022
Closed
@malud malud changed the base branch from master to release.1.8 April 4, 2022 10:04
@malud malud changed the base branch from release.1.8 to master April 4, 2022 10:05
@malud malud force-pushed the multiple-error_handler-labels-2 branch from 60ab20b to 0615d0b Compare April 4, 2022 15:18
@malud malud merged commit adb6162 into master Apr 4, 2022
@malud malud deleted the multiple-error_handler-labels-2 branch April 4, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @malud