Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor oauth #537

Merged
merged 16 commits into from
Jul 22, 2022
Merged

Refactor oauth #537

merged 16 commits into from
Jul 22, 2022

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Jul 13, 2022

  • Make OAuth2 a bit cleaner
  • Fix basic auth client authentication (client ID and secret must be URL encoded)

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch marked this pull request as ready for review July 13, 2022 09:38
Copy link
Contributor

@afflerbach afflerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@afflerbach afflerbach merged commit 36fb5ad into master Jul 22, 2022
@afflerbach afflerbach deleted the refactor-oauth branch July 22, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants