Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go routines leaks #564

Merged
merged 16 commits into from
Sep 9, 2022
Merged

Fix go routines leaks #564

merged 16 commits into from
Sep 9, 2022

Conversation

alex-schneider
Copy link
Contributor

Transport and use the "main" context to avoid leaks after reload (via -watch) of config.

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@malud malud force-pushed the fix-go-routines-leaks branch 2 times, most recently from d8f88e6 to c097d14 Compare September 8, 2022 10:13
@malud malud requested a review from johakoch September 8, 2022 10:34
johakoch
johakoch requested changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@johakoch johakoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some minor comment changes, this looks good to me.

main.go Outdated Show resolved Hide resolved
eval/context.go Outdated Show resolved Hide resolved
json/synced_json.go Outdated Show resolved Hide resolved
@johakoch johakoch merged commit b70d3e4 into master Sep 9, 2022
@johakoch johakoch deleted the fix-go-routines-leaks branch September 9, 2022 08:00
@malud malud linked an issue Oct 6, 2022 that may be closed by this pull request
json sync leaks go-routine with -watch flag #562
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johakoch johakoch johakoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

json sync leaks go-routine with -watch flag
2 participants
@alex-schneider @johakoch