Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make redirect_uri more static #589

Merged
merged 7 commits into from
Sep 14, 2022
Merged

make redirect_uri more static #589

merged 7 commits into from
Sep 14, 2022

Conversation

johakoch
Copy link
Collaborator

Make OAuth2/OIDC redirect_uri more static

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

Johannes Koch added 2 commits September 13, 2022 11:02
no need for redirect_uri to be evaluated, as long as a) relative valu…
2f1ad2a 
…es are made absolute wrt the client request's origin, and b) it can be set via env variables
no need for OAuth2 and SAML functions to be updated WithBeresp()
17344fe
@johakoch johakoch marked this pull request as ready for review September 13, 2022 11:33
@alex-schneider alex-schneider merged commit c46769a into master Sep 14, 2022
@alex-schneider alex-schneider deleted the static-redirect_uri branch September 14, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @alex-schneider