Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error chaining and handler selection #595

Merged
merged 7 commits into from
Sep 20, 2022
Merged

Error chaining and handler selection #595

merged 7 commits into from
Sep 20, 2022

Conversation

johakoch
Copy link
Collaborator

  • handle error from innermost to outermost
  • use all error kinds
  • in sequence: wrap all errors, except sequence errors
Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

Johannes Koch added 4 commits September 15, 2022 16:56
@johakoch johakoch force-pushed the error_chaining_handler_selection branch from 3dab3ed to 1ff95d7 Compare September 16, 2022 08:48
@johakoch johakoch marked this pull request as ready for review September 16, 2022 08:59
@alex-schneider alex-schneider merged commit 51ac083 into master Sep 20, 2022
@alex-schneider alex-schneider deleted the error_chaining_handler_selection branch September 20, 2022 13:01
malud pushed a commit that referenced this pull request Nov 22, 2022
Fixup 1.10 merge #595
3ae5bfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @alex-schneider