Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in default() function #596

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Conversation

johakoch
Copy link
Collaborator

use unsafe unified return type (like in stdlib.CoalesceFunc) from arguments ignoring cty.NilType arguments; and returning cty.NilType if all arguments are cty.NilType arguments (as expected by testcase default(request.cookies.undef, request.cookies.undef))


Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch marked this pull request as ready for review September 16, 2022 14:01
@johakoch johakoch changed the base branch from master to release.1.10 October 5, 2022 09:14
@johakoch johakoch changed the base branch from release.1.10 to master October 5, 2022 09:15
Johannes Koch added 2 commits October 5, 2022 11:20
… arguments ignoring NilType arguments; and returning NilType if all arguments are NilType arguments (as expected by testcase 'default(request.cookies.undef, request.cookies.undef)')
@johakoch johakoch changed the base branch from master to release.1.10 October 5, 2022 09:22
eval/lib/default.go Outdated Show resolved Hide resolved
@afflerbach afflerbach merged commit f6d8344 into release.1.10 Oct 17, 2022
@afflerbach afflerbach deleted the fix-default-function branch October 17, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants