Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding (m)TLS Support #615

Merged
merged 24 commits into from
Nov 15, 2022
Merged

Adding (m)TLS Support #615

merged 24 commits into from
Nov 15, 2022

Conversation

malud
Copy link
Collaborator

@malud malud commented Nov 3, 2022

Adding options to configure server tls with optional client certificate verification and per backend CA and client certificate configuration.

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

johakoch
johakoch reviewed Nov 10, 2022
View reviewed changes
config/tls.go Outdated Show resolved Hide resolved
Marcel Ludwig and others added 22 commits November 15, 2022 08:23
rename dev proxy files
b3f38cf
Add {server,backend} tls configuration
398c106
add server tls option and fixed h2 / proto logging
f2d8b99
prevent std log with unknown certificate client cancels
0a991f5
use wd join for client certs
363377e
add clientHello debug log
661b7e6
fixup logging, snake case
43f15db
move self signed certificate method to own file
e27afc1
move server related err wrapper to server file
a8badbf
Added cert load tests and fixed bugs; switched to elliptic self signed
e77e16e
Add server mtls support, backend tls client configuration; tests
3485b6e 
small code fixups here and there
Add merge option + test for tls blocks
facad14
fixup merge
9de99da
Add server clientCert leaf test
347caec
(ci) fixup github port permissions
23dad84
Add backend tls test
4c1062b
add documentation
53df367
@johakoch
Apply suggestions from code review
c26f071 
Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
Add client_certificate leaf or/and CA handling
55031e2
add internal counter for certificate creation to distinguish between …
d5d7e1a 
…them during testing
Fix unstable test expectation; sort mergeDefinitions labels
41b487d
docs refinement
aaa23e3
@malud malud merged commit 9d0f8c7 into master Nov 15, 2022
@malud malud deleted the server-tls branch November 15, 2022 09:35
@malud malud mentioned this pull request Jan 25, 2023
Open
@malud malud mentioned this pull request Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johakoch johakoch johakoch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malud @johakoch