Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send each proxy/request only once #624

Merged
merged 11 commits into from
Nov 22, 2022
Merged

Send each proxy/request only once #624

merged 11 commits into from
Nov 22, 2022

Conversation

johakoch
Copy link
Collaborator

Use existing proxy/request instead of creating a new one

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch changed the base branch from master to release.1.10 November 11, 2022 13:46
@johakoch johakoch marked this pull request as draft November 11, 2022 14:09
@johakoch johakoch marked this pull request as ready for review November 14, 2022 10:49
@malud malud self-assigned this Nov 15, 2022
@johakoch johakoch force-pushed the use-existing-proxy-request branch 3 times, most recently from 59e95f8 to 46124a1 Compare November 17, 2022 08:44
@johakoch johakoch changed the title Use existing proxy/request Send each proxy/request only once Nov 17, 2022
malud
malud requested changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@malud malud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work but could be more readable from the code perspective. Also I am not sure about client cancels and possible blockings, local pprof shows no leaks.

handler/producer/sequence.go Outdated Show resolved Hide resolved
handler/producer/sequence.go Outdated Show resolved Hide resolved
handler/producer/sequence.go Outdated Show resolved Hide resolved
handler/producer/sequence.go Outdated Show resolved Hide resolved
handler/producer/sequence.go Outdated Show resolved Hide resolved
server/http_endpoints_test.go Show resolved Hide resolved
@malud malud merged commit 9dffda2 into release.1.10 Nov 22, 2022
@malud malud deleted the use-existing-proxy-request branch November 22, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

Assignees

@malud malud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @malud