Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow evaluation for the defaults block #630

Merged
merged 14 commits into from
Nov 25, 2022
Merged

Allow evaluation for the defaults block #630

merged 14 commits into from
Nov 25, 2022

Conversation

malud
Copy link
Collaborator

@malud malud commented Nov 21, 2022 •
edited
Loading

Allow env variables and functions;

File merge is done on hclsyntax level to prevent early value evals without configured eval context.

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@malud malud changed the title merge without value eval Allow evaluation for the defaults block Nov 23, 2022
@malud malud marked this pull request as ready for review November 23, 2022 12:23
@johakoch johakoch merged commit 04cbe52 into master Nov 25, 2022
@johakoch johakoch deleted the fix-default-env-vars branch November 25, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johakoch johakoch johakoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malud @johakoch