Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint wildcard proxy wildcard #655

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Jan 6, 2023

Fixed endpoint wildcard/proxy wildcard combination where wildcard matches "":

  endpoint "/**" {
    proxy {
      backend {
        origin = "http://localhost:8081"
        path = "/**"
      }
    }
  }

  endpoint "/a/**" {
    proxy {
      backend {
        origin = "http://localhost:8081"
        path = "/b/**"
      }
    }
  }

before:

  • request GET / -> backend request GET /**
  • request GET /a -> backend request GET /b/**

now:

  • request GET / -> backend request GET /
  • request GET /a -> backend request GET /b

BTW, without

        path = "/**"

in the first endpoint, the backend request path was ok.

Non-empty-matches were ok, too:

  • request GET /c -> backend request GET /c
  • request GET /a/c -> backend request GET /b/c

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch marked this pull request as ready for review January 6, 2023 18:24
@johakoch johakoch changed the title Ep wildcard proxy wildcard Endpoint wildcard proxy wildcard Jan 9, 2023
@johakoch johakoch marked this pull request as draft January 9, 2023 15:19
@johakoch
Copy link
Collaborator Author

johakoch commented Jan 9, 2023

I'll rebase to release.1.11

@johakoch johakoch changed the base branch from master to release.1.11 January 9, 2023 15:23
@johakoch johakoch marked this pull request as ready for review January 9, 2023 15:23
@alex-schneider alex-schneider merged commit 330bf3f into release.1.11 Jan 17, 2023
@alex-schneider alex-schneider deleted the ep-wildcard-proxy-wildcard branch January 17, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants