Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom logs #658

Merged
merged 12 commits into from
Jan 23, 2023
Merged

Fix custom logs #658

merged 12 commits into from
Jan 23, 2023

Conversation

johakoch
Copy link
Collaborator

  • use slice instead of buffered channel
  • eval upstream custom_log_fields during backend roundtrip
Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch marked this pull request as ready for review January 12, 2023 16:36
@alex-schneider alex-schneider merged commit 303f6f1 into master Jan 23, 2023
@alex-schneider alex-schneider deleted the fix-custom-logs branch January 23, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @alex-schneider