Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom log eval error loop #659

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Custom log eval error loop #659

merged 4 commits into from
Jan 19, 2023

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Jan 16, 2023 •
edited
Loading

Don' trigger custom logs for log levels lower than info

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch marked this pull request as ready for review January 16, 2023 16:31
@alex-schneider alex-schneider merged commit e0f5f9e into master Jan 19, 2023
@alex-schneider alex-schneider deleted the custom-log-eval-error-loop branch January 19, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @alex-schneider