Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic auth realm param #715

Merged
merged 3 commits into from
Feb 13, 2023
Merged

basic auth realm param #715

merged 3 commits into from
Feb 13, 2023

Conversation

johakoch
Copy link
Collaborator

realm param value as quoted string

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch linked an issue Feb 10, 2023 that may be closed by this pull request
Basic Auth: WWW-Authenticate realm param value must be quoted string #714
Closed
@johakoch johakoch marked this pull request as ready for review February 10, 2023 17:47
@alex-schneider alex-schneider merged commit 774713e into master Feb 13, 2023
@alex-schneider alex-schneider deleted the 714-realm-param branch February 13, 2023 11:19
johakoch added a commit that referenced this pull request Feb 13, 2023
@johakoch
basic auth realm param (#715)
be46a07 
* test for quoted realm param value

* fix: quoted realm param value

* changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic Auth: WWW-Authenticate realm param value must be quoted string
2 participants
@johakoch @alex-schneider