Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

777 duplicate CORS response headers #804

Merged
merged 8 commits into from
Apr 8, 2024

Conversation

johakoch
Copy link
Collaborator

When CORS enabled, remove CORS response headers possibly copied from backend, set/add CORS response headers before regular header modifiers.


Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch requested a review from malud February 12, 2024 17:09
@johakoch johakoch marked this pull request as ready for review February 12, 2024 17:17
@johakoch johakoch linked an issue Feb 16, 2024 that may be closed by this pull request
@malud malud force-pushed the 777-duplicate-cors-response-headers branch from 7e294b7 to 5e33b54 Compare April 8, 2024 09:17
Copy link
Collaborator

@malud malud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johakoch I've removed the before/after switch since we have no usecase for this atm. I prefer a simple and fast code base here. Please have a look at my changes and merge if ok.

@johakoch johakoch merged commit ec5f39d into master Apr 8, 2024
2 checks passed
@johakoch johakoch deleted the 777-duplicate-cors-response-headers branch April 8, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicate CORS headers leads to browser CORS errors
2 participants