Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eval.toSlice() #805

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Fix eval.toSlice() #805

merged 4 commits into from
Apr 8, 2024

Conversation

johakoch
Copy link
Collaborator

  • added bool handling to eval.toSlice()
  • added tests for use of eval.toSlice() for several HCL attributes

TODOs to be fixed in #759 (add bool handling to eval.toString())

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch mentioned this pull request Feb 16, 2024
Merged
@johakoch johakoch marked this pull request as ready for review February 16, 2024 13:15
@johakoch johakoch requested a review from malud February 16, 2024 13:16
@malud malud merged commit 4cbe626 into master Apr 8, 2024
2 checks passed
@malud malud deleted the fix-toSlice branch April 8, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

Assignees

@malud malud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @malud