Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Scala3 prebuiltBinaries paths inside archives to the fixed layout in 3.6.0+ #256

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

WojciechMazur
Copy link
Contributor

In 3.5 series the the paths inside the archives had incorrect layout that introduce 1 additional top-level directory. It was accidently fixed in 3.6 but coused incompatibility when installing native runnners.

tar -tvf scala3-3.6.2-RC3-aarch64-apple-darwin.tar.gz
drwxr-xr-x  0 root   root        0 Nov 28 17:03 ./
-rwxr--r--  0 root   root     2613 Nov 28 16:56 ./bin/scalac
-rwxr--r--  0 root   root     2094 Nov 28 16:56 ./bin/scaladoc
-rw-r--r--  0 root   root     2818 Nov 28 16:56 ./bin/scaladoc.bat
-rwxr--r--  0 root   root     1640 Nov 28 16:56 ./bin/scala
-rwxr--r--  0 root   root     1883 Nov 28 16:56 ./bin/scala_legacy
-rw-r--r--  0 root   root     1789 Nov 28 16:56 ./bin/scala.bat
-rw-r--r--  0 root   root     3200 Nov 28 16:56 ./bin/scalac.bat
-rw-r--r--  0 root   root       73 Nov 28 17:03 ./VERSION
...
tar -tvf scala3-3.5.2-aarch64-apple-darwin.tar.gz 
-rwxr-xr-x  0 root   root     2609 Oct 16 12:20 scala3-3.5.2-aarch64-apple-darwin/bin/scalac
-rwxr-xr-x  0 root   root      975 Oct 16 12:20 scala3-3.5.2-aarch64-apple-darwin/bin/common
-rwxr-xr-x  0 root   root     2090 Oct 16 12:20 scala3-3.5.2-aarch64-apple-darwin/bin/scaladoc
-rwxr-xr-x  0 root   root     1538 Oct 16 12:20 scala3-3.5.2-aarch64-apple-darwin/bin/common.bat
-rwxr-xr-x  0 root   root     2814 Oct 16 12:20 scala3-3.5.2-aarch64-apple-darwin/bin/scaladoc.bat
-rwxr-xr-x  0 root   root     1632 Oct 16 12:20 scala3-3.5.2-aarch64-apple-darwin/bin/scala
-rwxr-xr-x  0 root   root     1879 Oct 16 12:20 scala3-3.5.2-aarch64-apple-darwin/bin/scala_legacy
-rwxr-xr-x  0 root   root     1781 Oct 16 12:20 scala3-3.5.2-aarch64-apple-darwin/bin/scala.bat
...

Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@tgodzik tgodzik merged commit f062e31 into coursier:main Nov 29, 2024
1 check passed
@WojciechMazur WojciechMazur deleted the fix/scala3.6-paths branch November 29, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants