Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 16 #418

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

BalmungSan
Copy link
Contributor

Fixes #410

@BalmungSan BalmungSan force-pushed the upgrade-node-16 branch 2 times, most recently from 3e0aa53 to ed98e66 Compare October 18, 2022 17:02
@daddykotex
Copy link

Oh wow, 8 hours ago. I had not realized that.

Good job, I was going to ping someone for review but we'll give them time to breathe!

Copy link

@daddykotex daddykotex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I have not reviewed the package-lock.json carefully.

daddykotex added a commit to disneystreaming/smithy4s that referenced this pull request Oct 19, 2022
There is also coursier/cache-action that needs upgrading
but we'll open a PR when coursier/cache-action#418
is merged
src/restore.ts Outdated Show resolved Hide resolved
@daddykotex
Copy link

can you approve the workflow @alexarchambault just so we have a green pipeline and see if this needs work?

Copy link
Member

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BalmungSan!

@alexarchambault alexarchambault merged commit 566e01f into coursier:main Oct 19, 2022
@BalmungSan BalmungSan deleted the upgrade-node-16 branch October 19, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to node 16
3 participants