Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignoring job and matrix jobs as part of cache key #512

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

ihostage
Copy link
Contributor

@ihostage ihostage commented Oct 2, 2023

Hi, @alexarchambault!
This feature will be very useful for us in Playframework. We have about 15 pair (coursier + ivy) very similar cache entries per build (summary more then 20Gb). But in fact we need only one pair of them about 1.4Gb.
It can give us ability don't exceed a GitHub Actions Cache size limit (10Gb).

PS: Changes is very simple, but I don't know how to test it. Sorry, TS isn't my skill 🤷‍♂️

@alexarchambault
Copy link
Member

Nice idea! Not sure what the error we get on CI means…

@ihostage
Copy link
Contributor Author

ihostage commented Oct 2, 2023

Hm 🤔 Looks like getBooleanInput can't work with undefined property.

@ihostage
Copy link
Contributor Author

ihostage commented Oct 2, 2023

https://github.com/actions/toolkit/pull/725/files

If required set to be false, the input should have a default value in action.yml.

@ihostage
Copy link
Contributor Author

ihostage commented Oct 2, 2023

My mistake, default values should be in action.yml instead of TS code

@ihostage
Copy link
Contributor Author

ihostage commented Oct 3, 2023

@alexarchambault Can you approve this to run GitHub Actions to test my changes? 🙏

@ihostage
Copy link
Contributor Author

Hi, @alexarchambault!
Any chance to release a new version cache-action with this changes? 🙏

@mkurz
Copy link
Contributor

mkurz commented Nov 9, 2023

@alexarchambault can you have a look at this pull request? Thanks!

Copy link
Member

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexarchambault alexarchambault merged commit c98bc3a into coursier:main Nov 9, 2023
3 checks passed
@mkurz
Copy link
Contributor

mkurz commented Nov 9, 2023

@alexarchambault A new release would be nice as well 😉 thanks!

@ihostage ihostage deleted the ignore-job-matrix branch November 9, 2023 14:30
@mkurz
Copy link
Contributor

mkurz commented Nov 9, 2023

Thanks @alexarchambault!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants