Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aarch64 #369

Merged
merged 21 commits into from
Apr 17, 2023
Merged

Add support for aarch64 #369

merged 21 commits into from
Apr 17, 2023

Conversation

xRuiAlves
Copy link
Contributor

@xRuiAlves xRuiAlves commented Mar 13, 2023

Currently the setup action only supports the x86_64 architecture.

coursier also publishes binaries for aarch64 (e.g., v2.1.0-RC4).

Leveraging the system's process.arch to choose which file architecture to download.

const arc = `${guid}.gz`
await cli.exec('mv', [guid, arc])
csBinary = arc
const archive = `${guid}.gz`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed these arc variables to archive - With the introduction of the new architecture variable, arc could be ambiguous, and the renaming enhances clarity on this.

Copy link
Member

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

There's no need to update things under dist, the CI will handle it on its own (it updates things locally, and later opens PRs to update things in main if needed). The changes there can be removed.

I also left one comment (might be more of a question)

.github/workflows/test.yml Outdated Show resolved Hide resolved
@xRuiAlves
Copy link
Contributor Author

Additionally, I've refactored the action logic to make use of the system's process.arch instead of relying on the user specifying the architecture. I will update the PR description accordingly.

@xRuiAlves
Copy link
Contributor Author

Hey @alexarchambault! Was wondering if you had a chance to taking a look at this in the past few weeks?

Copy link
Member

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xRuiAlves!

@alexarchambault alexarchambault merged commit b293fe7 into coursier:main Apr 17, 2023
tgodzik added a commit to tgodzik/setup-action that referenced this pull request Nov 5, 2024
…n/typescript-eslint/eslint-plugin-6.10.0

build(deps-dev): bump @typescript-eslint/eslint-plugin from 6.9.1 to 6.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants