-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for aarch64
#369
Conversation
Given that we also have a concept of 'architecture' now, renaming 'arc' to 'archive' for the sake of clarity.
const arc = `${guid}.gz` | ||
await cli.exec('mv', [guid, arc]) | ||
csBinary = arc | ||
const archive = `${guid}.gz` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed these arc
variables to archive
- With the introduction of the new architecture
variable, arc
could be ambiguous, and the renaming enhances clarity on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There's no need to update things under dist
, the CI will handle it on its own (it updates things locally, and later opens PRs to update things in main
if needed). The changes there can be removed.
I also left one comment (might be more of a question)
Additionally, I've refactored the action logic to make use of the system's |
Hey @alexarchambault! Was wondering if you had a chance to taking a look at this in the past few weeks? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xRuiAlves!
…n/typescript-eslint/eslint-plugin-6.10.0 build(deps-dev): bump @typescript-eslint/eslint-plugin from 6.9.1 to 6.10.0
Currently the setup action only supports the
x86_64
architecture.coursier
also publishes binaries foraarch64
(e.g., v2.1.0-RC4).Leveraging the system's
process.arch
to choose which file architecture to download.