Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom repository variables #631

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Add custom repository variables #631

merged 3 commits into from
Aug 15, 2024

Conversation

Quafadas
Copy link
Contributor

For the situation, in which one is attempting to use this action in a (corporate) environment, where standard repositories are not available, but proxied by some other tool - e.g. antifactory.

@Quafadas Quafadas changed the title Add repository variables Add custom repository variables Aug 14, 2024
Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Looks like you need to run prettifier first :(

@Quafadas
Copy link
Contributor Author

Arg - I think I always forget that :-/, thanks for the tip.

Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgodzik tgodzik merged commit 00fede1 into coursier:main Aug 15, 2024
6 checks passed
@ghostbuster91
Copy link

Hi @tgodzik could you please release a new version? The latest release was in February. I know that I can use the action with the latest changes either by pinning it to a particular commit or the main branch but we prefer to use standard tags. Many thanks!

@tgodzik
Copy link
Collaborator

tgodzik commented Sep 17, 2024

I tagged a new version, I think that should be enough? Or do we need to release it on the marketplace? If the last one is needed then we would need to ask Alex to enable that for the org.

@ghostbuster91
Copy link

I tagged a new version, I think that should be enough? Or do we need to release it on the marketplace?

I checked and I am able to use it by specifying the exact tag @v1.3.6 but using simply @v1 doesn't work.

@tgodzik
Copy link
Collaborator

tgodzik commented Sep 20, 2024

Ach, it's because everything is based on tags. I updated the tags to the newest version

tgodzik pushed a commit to tgodzik/setup-action that referenced this pull request Nov 5, 2024
Co-authored-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants