Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message about extrapolation is incorrect #159

Closed
courtiol opened this issue Nov 7, 2022 · 0 comments
Closed

Message about extrapolation is incorrect #159

courtiol opened this issue Nov 7, 2022 · 0 comments
Assignees
@courtiol
Labels
invalid signals
Milestone
version 0.9.1

Comments

@courtiol
Copy link
Owner

courtiol commented Nov 7, 2022

When fitting the calibration model, the program tests if predicted values are outside the range.
That is however fine in the context of spatial smoothing.
Instead, what should be tested are whether predictions consider values outside the observed range for the predictors.
See email from FR (2022/10/03) for details.
@courtiol courtiol self-assigned this Nov 7, 2022
@courtiol courtiol added this to the version 0.9.1 milestone Sep 24, 2023
courtiol added a commit that referenced this issue Sep 25, 2023
@courtiol
Remove wrong message about extrapolation (fixes #159)
7c1f979
courtiol added a commit that referenced this issue Sep 25, 2023
@courtiol
Switch to terra and drop raster and sp (#168)
491723c 
* Update Roxygen

* Add terra

* Store shape files for polygons

terra does not seem to allow for the use of rda...

* prepraster uses terra

* Bump version number for devel

* Fix Roxygen issues

* Reoxygenise

* Swith to terra

* Fix wrong statement

* Emmulate lazy loading for terra data

* Fix extract calls

* Re-export more terra fns

* Remove old rda files

* Add tif for elevation

* Some tif files now need to be tracked

* Switch to terra (fixes #161, fixes #90)

* Silence spaMM expected warnings (fixes #115)

* Fix test

* Change caused by new version of Roxygen

* Change filename

* Make path definition more robust

* CountryBorders and OceanMask are now of class SpatVector

* Remove raster and sp dependency

* Update NEWS

* Improve style and comments

* elevatr behaviour seems to have changed...

* Add info about crash caused by timeout

* Slight improvement on how to handle paths

* Fix broken tests

* Remove maps (not used)

* Typo. Fixes #160

* Fix typo

* terra:vect does not understand tibbles

* Fixes #165

* Add comment

* Reoxygenise

* elevatr moved to Suggests. Fixes #157

* Change timeout (fixes #148)

* Fix documentation (fixes #158)

* Remove wrong message about extrapolation (fixes #159)

* Make second display consistent

* Bump version number

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@courtiol courtiol

Labels
invalid signals
Projects
None yet
Milestone
version 0.9.1
Development

No branches or pull requests
1 participant
@courtiol