fix(WEB-7276): avoid sliver of content being viewable below the StickyFooter

[jkatofskyCoveo]

Proposed Changes

Put down the sticky footer down by one pixel to avoid the visual issue reported here

[github-actions]

✔️ Live demo of your latest successful build available here.

[FelixBlaisThon]

I couldn't see the sliver in your previous PR. was it on a 4k screen ?

[jkatofskyCoveo]

@FelixBlaisThon, hmm, it's finnicky to replicate, but I don't think it has to do with 4K, rather I think it's a rounding error with how CSS calculates the bottom of a sticky element or something. Here is the modal in dev on my laptop screen (1920 X 1200). You can see the sliver

[FelixBlaisThon]

I'm sorry to be annoying, but I am not able to replicate even using the devTools of my browser (chrome in my case) and explicitly setting my resolution to 1920x1200 (see screenshot). Also, when I add bottom: -1px to the stickyfooter, I have a flickering footer (see recording below)

Screen.Recording.2024-11-27.at.9.36.25.AM.mov

What are your browser and OS ?

[jkatofskyCoveo]

Haha no you're not annoying, it's this bug that is annoying @FelixBlaisThon 😅

Windows 11, Chrome 131.

The flickering footer is indeed another issue, but for those of us who can replicate the sliver of content underneath, the flickering happens with or without the bottom: -1px 😕

[FelixBlaisThon]

Haha no you're not annoying, it's this bug that is annoying @FelixBlaisThon 😅

Windows 11, Chrome 131.

The flickering footer is indeed another issue, but for those of us who can replicate the sliver of content underneath, the flickering happens with or without the bottom: -1px 😕

Ok. I think we have to maybe check that before merging any fix (at least remove any flickering, with or without the bottom: -1px.. I will create a JIRA so that we can investigate it. From the time being, I would suggest to close this PR and link the JIRA to this one https://coveord.atlassian.net/browse/ADUI-10401