Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modeldetails): add modelDetails for CPR #892

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

lprovost-coveo
Copy link
Contributor

@lprovost-coveo lprovost-coveo commented Dec 4, 2024

New properties with more specific names are now available for consumption by CPR models

The list of property changes can be seen here:
image

There's an open PR with the changes from the BE but since they're all optional this PR can go first and will unblock working in the adui.

https://github.com/coveo-platform/ml-config-service/pull/2415

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)

Technically they're already in production on swagger and can be seen on existing models, the addition of it in mlconfig only allows the adui to consume the properties from our own definitions

  • JSDoc annotates each property added in the exported interfaces

Not applicable, we do not document these properties as can be seen with the other properties in this interface.

  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@lprovost-coveo lprovost-coveo force-pushed the feat/MLX-1763 branch 2 times, most recently from 5539ffb to 92308c5 Compare December 4, 2024 18:10
@lprovost-coveo lprovost-coveo marked this pull request as ready for review December 4, 2024 18:15
@lprovost-coveo lprovost-coveo requested review from a team as code owners December 4, 2024 18:15
New properties with more specific names are now available for consumption by CPR models
@lprovost-coveo lprovost-coveo added this pull request to the merge queue Dec 9, 2024
Merged via the queue into master with commit 9942f57 Dec 9, 2024
5 checks passed
@lprovost-coveo lprovost-coveo deleted the feat/MLX-1763 branch December 9, 2024 14:20
Copy link

github-actions bot commented Dec 9, 2024

🎉 This PR is included in version 57.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

paulgerold pushed a commit that referenced this pull request Dec 16, 2024
New properties with more specific names are now available for consumption by CPR models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants