Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update angular to 18 #4795

Merged
merged 7 commits into from
Dec 30, 2024
Merged

chore(deps): update angular to 18 #4795

merged 7 commits into from
Dec 30, 2024

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Dec 17, 2024 •
edited
Loading

kit-282

This was blocking other updates because of peerDeps

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 242.9 242.9 0
commerce 354 354 0
search 414 414 0
insight 405.2 405.2 0
recommendation 255.1 255.1 0
ssr 407.4 407.4 0
ssr-commerce 371.3 371.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme changed the title chore(deps): update angular chore(deps): update angular to 18 Dec 17, 2024
@alexprudhomme alexprudhomme marked this pull request as ready for review December 17, 2024 15:47
@alexprudhomme alexprudhomme requested a review from a team as a code owner December 17, 2024 15:47
@github-actions GitHub Actions

This comment was marked as spam.

Sign in to view
@alexprudhomme alexprudhomme requested a review from a team as a code owner December 19, 2024 19:19
@alexprudhomme alexprudhomme added this pull request to the merge queue Dec 30, 2024
Merged via the queue into master with commit 425a5fa Dec 30, 2024
124 checks passed
@alexprudhomme alexprudhomme deleted the angular-upgrade branch December 30, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexprudhomme @fbeaudoincoveo