Latest release is missing the v

[bmaupin]

This is pretty trivial so feel free to close it, but the latest release is 1.1.3 whereas all the other release tags start with a v, e.g. v1.1.2.

Thanks!

[hartwork]

My vote for adding a copy named v1.1.3 with v too, e.g. because I am worried that mixing schemes will confuse GitHub Dependabot thank you!

CC @afinetooth

[jrfnl]

Could this be why the below does not work ?

uses: coverallsapp/github-action@v1

It is generally strongly recommended to always "lock" actions to a version to prevent CI builds to unexpectedly start failing due to a new major of an action having been released. That is currently not possible with this action.

[jrfnl]

Related to / duplicate of #94

[hartwork]

@jrfnl @v1 is a moving Git tag that other repos keep moving whenever they create a new v1.x.y tag, by themselves. Ideally, Git tags never move, so it's arguably a hack. The reason it doesn't work here is because there is no tag named v1 at https://github.com/coverallsapp/github-action/tags .

[jrfnl]

@hartwork Thanks for the explanation. Sounds like something which should be solved.

[prescottprue]

@jrfnl I'm not seeing any CI in the repo currently if you are implementing in a Github Actions workflow, I've done that with a simple step to push the change to a branch after releasing (this example grabs version from the package.json since you seem to be managing that manually):

      - name: Push updates to branch for major version
        # If a new version is published, i.e. v1.2.3 then this step will update
        # branch "v1" to this commit.
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        run: |
          git push https://x-access-token:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git HEAD:refs/heads/v$(cat package.json | jq '.version')

Using semantic-release like Cypress does with their Github Action makes it even cleaner since you can detect if a version was released:

      - name: Semantic Release
        uses: cycjimmy/semantic-release-action@v2
        id: semantic
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

      - name: Push updates to branch for major version
        # If a new version is published, i.e. v1.2.3 then this step will update
        # branch "v1" to this commit.
        if: steps.semantic.outputs.new_release_published == 'true'
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        run: |
          git push https://x-access-token:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git HEAD:refs/heads/v${{steps.semantic.outputs.new_release_major_version}}

I'm open to help setting up the CI tooling for release as well as commit linting if you are interested, but up to you since semantic-release is more strict than some projects want

[jrfnl]

@prescottprue I think your suggestions are great, however, I'm not a maintainer of this repo, just a user 🤷🏻‍♀️

I imagine @nickmerwin may welcome your help though ?

[mrexox]

Hey! There is a new release with the fix, and also there is a v1 release which is finally what many people wanted.