-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove static Coverage object #393
Remove static Coverage object #393
Conversation
|
||
public override string ToString() | ||
{ | ||
return JsonConvert.SerializeObject(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for simplicity I used Json serializer.
public uint Ordinal; | ||
} | ||
|
||
public class BranchKeyConverter : TypeConverter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need custom converter because Json serializer does not support serialization of complex dictionary key
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
=========================================
- Coverage 86.96% 86.26% -0.7%
=========================================
Files 16 17 +1
Lines 2178 2220 +42
=========================================
+ Hits 1894 1915 +21
- Misses 284 305 +21 |
@tonerdo fixed conflicts...the change touch a lot of file if you can review this before others we avoid too much conflicts...I think(hope) this is the only "huge" update of checklist. |
@MarcoRossignoli this is a good start. I'm a bit skeptical about the drastic changes and I wonder if things could be simpler. The most important things that need to be serialized in the Also, it's best not to do major style refactorings for important features so it doesn't get so large |
Replaced by #409 keep this PR as useful notes. |
contributes to #387
closes #364
replace #366
InstrumentationTask.Coverage
and used[Output]
msbuild parameterInstrumenter state is serialized using
IInstrumentStateSerializer
for now implemented with JsonSerializerIInstrumenter
andICoverageCalculator
Instrumentation
andCoverage
/cc @tonerdo @petli @sharwell