Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve instrumentation tests #527

Merged
merged 7 commits into from
Sep 4, 2019
Merged

Improve instrumentation tests #527

merged 7 commits into from
Sep 4, 2019

Conversation

daveMueller
Copy link
Collaborator

Closes #496

@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Aug 31, 2019 •
edited
Loading

Thanks @daveMueller I was on vacation I'll take a look asap!
Sorry for the delay!

@MarcoRossignoli MarcoRossignoli added the enhancement General enhancement request label Aug 31, 2019
@daveMueller @MarcoRossignoli
Update test/coverlet.core.tests/Instrumentation/InstrumenterTests.cs
f2dc941 
code review

Co-Authored-By: Marco Rossignoli <marco.rossignoli@gmail.com>
MarcoRossignoli
MarcoRossignoli approved these changes Sep 4, 2019
View reviewed changes
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank's!

@MarcoRossignoli MarcoRossignoli merged commit 75520dd into coverlet-coverage:master Sep 4, 2019
@daveMueller daveMueller deleted the 495_ImproveInstrumentationTests branch September 4, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoRossignoli MarcoRossignoli MarcoRossignoli approved these changes

@tonerdo tonerdo Awaiting requested review from tonerdo

@petli petli Awaiting requested review from petli

Assignees
No one assigned
Labels
enhancement General enhancement request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve tests
2 participants
@daveMueller @MarcoRossignoli